-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patching #57, $uri->canonical unconditionally returns a clone #58
Conversation
@doriantaylor can you squash these commits into one, and add "closes #57" to the commit message? |
1b6ce3d
to
016be42
Compare
All requested changes made. Worth noting re |
@karenetheridge there have been some changes. Can you review them? |
are these changes satisfactory? |
@doriantaylor not sure if @karenetheridge saw this. I'll touch base with her tomorrow so we can see about getting this merged. |
Thanks @doriantaylor and @karenetheridge! |
@doriantaylor I just reverted this change for the time being. Please see libwww-perl/HTTP-Message#121 Since this was breaking |
Even money on the test being the problem. I'll check it out. |
eh spoke too soon; looking at |
This change makes
$uri->canonical
uniformly return a cloned object. Erstwhile it returned$self
if there was nothing to change, for the stated purpose of efficiency, although benchmarks suggest this turns out to be only about a 7% gain on an operation that is measured in microseconds, and only in the no-op scenario.